Verify array before try to access any position

diegoholiveira · Dec 8, 2023 · fcb4721 · fcb4721
1 parent f01aadf
commit fcb4721
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/jsonlogic_test.go b/jsonlogic_test.go
@@ -807,6 +807,16 @@ func TestIssue71_example_max(t *testing.T) {
 	assert.JSONEq(t, expected, result.String())
 }
 
+func TestIssue74(t *testing.T) {
+	logic := strings.NewReader(`{"if":[ false, {"var":"values.0.categories"}, "else" ]}`)
+	data := strings.NewReader(`{ "values": [] }`)
+
+	var result bytes.Buffer
+	_ = Apply(logic, data, &result)
+	expected := `"else"`
+	assert.JSONEq(t, expected, result.String())
+}
+
 func TestJsonLogicWithSolvedVars(t *testing.T) {
 	rule := json.RawMessage(`{
 		"or":[

diff --git a/vars.go b/vars.go
@@ -91,7 +91,12 @@ func getVar(value, data interface{}) interface{} {
 		}
 
 		if isSlice(data) {
-			_value = data.([]interface{})[int(toNumber(part))]
+			pos := int(toNumber(part))
+			container := data.([]interface{})
+			if pos >= len(container) {
+				return _default
+			}
+			_value = container[pos]
 		}
 
 		if _value == nil {