feat: resend invitation #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubkoci
requested changes
Jan 11, 2024
There was a problem hiding this comment.
We shouldn't put responsibility for sending an e-mail to the submission service. I also added a few cosmetic suggestions, otherwise, looks quite nice 👍
Right now, we can just move the sendInvitationEmail into emailClient. Eventually, we can create an emailService if the emailClient grows too much.
packages/frontend/src/app/invitations/components/ResendInvitation.tsx
Outdated
Show resolved
Hide resolved
packages/frontend/src/app/invitations/components/ResendInvitation.tsx
Outdated
Show resolved
Hide resolved
packages/frontend/src/app/invitations/components/ResendInvitation.tsx
Outdated
Show resolved
Hide resolved
packages/frontend/src/app/invitations/components/ResendInvitation.tsx
Outdated
Show resolved
Hide resolved
andrii-uhryn-absa
force-pushed
the
feat/resend-invitation
branch
from
41a3aa8
to
051048d
Compare
andrii-uhryn-absa
force-pushed
the
feat/resend-invitation
branch
from
ed7ed13
to
4d221b7
Compare
jakubkoci
reviewed
Jan 16, 2024
There was a problem hiding this comment.
It seems we'll have to introduce an email service where we can put the logic that's currently duplicated in emailClientStub. At the same time, we should reconsider how do we work with the stub in the tests, when to init or remove all messages so that each test has same original conditions and they don't influence each other.
jakubkoci
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-01-11.at.11.47.59.mov