-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: resend invitation #203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't put responsibility for sending an e-mail to the submission service. I also added a few cosmetic suggestions, otherwise, looks quite nice 👍
Right now, we can just move the sendInvitationEmail
into emailClient
. Eventually, we can create an emailService
if the emailClient
grows too much.
packages/frontend/src/app/invitations/components/ResendInvitation.tsx
Outdated
Show resolved
Hide resolved
packages/frontend/src/app/invitations/components/ResendInvitation.tsx
Outdated
Show resolved
Hide resolved
packages/frontend/src/app/invitations/components/ResendInvitation.tsx
Outdated
Show resolved
Hide resolved
packages/frontend/src/app/invitations/components/ResendInvitation.tsx
Outdated
Show resolved
Hide resolved
41a3aa8
to
051048d
Compare
ed7ed13
to
4d221b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems we'll have to introduce an email service where we can put the logic that's currently duplicated in emailClientStub. At the same time, we should reconsider how do we work with the stub in the tests, when to init or remove all messages so that each test has same original conditions and they don't influence each other.
Screen.Recording.2024-01-11.at.11.47.59.mov