chore: set backend url on frontend #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump `bitnami/moongodb` * Add config for `FRONTEND_URL` and `NEXT_PUBLIC_BACKEND_URL` * Add necessary Ingress and Service changes to correctly route Frontend/Backend * Bump Datadog JSLib
rblaine95
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rblaine95 I added a new env
NEXT_PUBLIC_BACKEND_URL, that's for the frontend app to know what's the backend endpoint. There is alsoFRONTEND_URLenv for backend to know what's the frontend to correctly set CORS.Now, could you please create a new domain for the frontend server and set those two variables properly?
It should be something like
That assumes we preserve the current backend address. Maybe we can change both of them in the following way:
In the end, it's mainly up to you, how you want to deploy it.