Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IPv6 detection (and console errors). #31

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

eyecatchup
Copy link

The previous regex failed for a couple of valid IPv6 address notations. This commit updates the regex to work for (almost) all valid IPv6 address notations. Also it adds an additional check for the result of the exec call to prevent console error messages in cases where the regex fails.

The previous regex failed for a couple of valid IPv6 address notations. This commit updates the regex to work for (almost) all valid IPv6 address notations. Also it adds an additional check for the result of the exec call to prevent console error messages in cases where the regex fails.
@eyecatchup
Copy link
Author

Just saw it now. This PR actually combines #24 and #28 :)

@eyecatchup
Copy link
Author

Working demo here: http://eyecatchup.rocks/webrtc-ips/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant