-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constituency Map Styling #16
Conversation
Why did you resize the map to be narrower? I thought Dwai wanted the map to take up more space on the screen with a smaller election year column. |
In the slack, Dwai said to clip the map at India's borders so that it doesn't show China. |
I think the solution would be to make the container larger while finding a way to make the India portion of the map take up more of the container (as you mentioned in the "Tasks Left" section). As it is now, there's a lot of unused space on the page, and it may be harder to interact with the map on smaller screens. In the meantime, if we don't want to show the map portion for other regions, the TileLayer of the MapBase can be removed to show only the geojson layer on a blank background. Let's see what Dwai thinks tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great! We'll keep the page layout as is, as discussed in the meeting since the map fits about as well as it can in the container, and we might need to utilize the space on the side later. My concern about the whitespace/narrow map at smaller desktop screen sizes is probably best addressed by adjusting the breakpoints, which we will have to adjust for mobile.
Major Changes:
Tasks Left