Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylibfdt: Use python.extension_module() #109

Closed
wants to merge 1 commit into from
Closed

pylibfdt: Use python.extension_module() #109

wants to merge 1 commit into from

Conversation

ernestask
Copy link

This commit avoid using deprecated setuptools utilities and builds the module directly using Meson.

This commit avoid using deprecated setuptools utilities and builds the
module directly using Meson.

Signed-off-by: Ernestas Kulik <[email protected]>
@ernestask
Copy link
Author

ernestask commented Jul 28, 2023

I did some quick sanity checking by replacing the module and running make check, but it turns out that #108 (the issue fixed by it) was causing tests to not run.

@dgibson
Copy link
Owner

dgibson commented Jul 29, 2023

With this patch meson builds fail for me with lots of errors from swig.

We also still get warnings when building with make because of deprecated setuptools. I'd prefer to avoid diverging how the module is built between make and meson if we can.

@ernestask
Copy link
Author

The thing about build systems is that they are not supposed to mimic one another. If you want to use Meson like Make, then it’s best to drop support for it.

@ernestask
Copy link
Author

But feel free to close this if you disagree, I can maintain a fork with these changes.

@dgibson
Copy link
Owner

dgibson commented Jul 29, 2023

The thing about build systems is that they are not supposed to mimic one another. If you want to use Meson like Make, then it’s best to drop support for it.

It's not a question of wanting to use meson like make, it's a question of (confidently) producing similar results. What I'm worried about here is the possibility of subtle incompatibilities in the python package as produced by meson versus as produced by setuptools.

@ernestask ernestask closed this Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants