fix: async flow and integrate prom-client #91
+289
−173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eshankvaish
reviewed
Oct 23, 2024
arunjaindev
force-pushed
the
fix/async-flow
branch
from
5984aa0
to
d84c079
Compare
eshankvaish
requested changes
Oct 23, 2024
eshankvaish
requested changes
Oct 24, 2024
| @@ -129,28 +132,27 @@ class NotificationService { | |||
| setting.event_type_id = event.eventTypeId | |||
| setting.pipeline_id = 0 | |||
| setting.config = event.payload | |||
| h.sendAndLogNotification(event, sdk,setting,{"dest": "slack"}, slackTemplateConfig) | |||
| }) | |||
| await h.sendAndLogNotification(event, sdk,setting,{"dest": "slack"}, slackTemplateConfig) | |||
There was a problem hiding this comment.
We need to test if await is required everywhere as this might increase the response time
eshankvaish
previously approved these changes
Oct 25, 2024
arunjaindev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.