Feat async install helm #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ash-exp
requested changes
Nov 20, 2023
pkg/service/HelmAppService.go
Outdated
| } | ||
| _ = impl.pubsubClient.Publish(pubsub_lib.HELM_CHART_INSTALL_STATUS_TOPIC, string(data)) | ||
| }() | ||
| rel, err := helmClientObj.InstallChart(context.Background(), chartSpec) |
There was a problem hiding this comment.
it should be helmClientObj.InstallChart(ctx, chartSpec)
| } else { | ||
| impl.logger.Errorw("Error in upgrade release with chart info", "err", err) | ||
| impl.logger.Debug("Upgrading release with chart info") | ||
| _, err = helmClientObj.UpgradeReleaseWithChartInfo(ctx, chartSpec) |
There was a problem hiding this comment.
as the async install/upgrade flow is flag driven, we should expose a flag in our gRPC payload (e.g: runInContext: bool) and use native context/ context.background() accordingly. The current flow will break for sync deployments as it will run with a default timeout now.
pkg/service/HelmAppService.go
Outdated
| _, err = helmClientObj.UpgradeReleaseWithChartInfo(ctx, chartSpec) | ||
| if UpgradeErr, ok := err.(*driver.StorageDriverError); ok { | ||
| if UpgradeErr != nil { | ||
| if UpgradeErr.Err == driver.ErrReleaseNotFound { |
There was a problem hiding this comment.
instead of driver.ErrReleaseNotFound, it should be driver.ErrNoDeployedReleases
…ll-flag fixed: helm upgrade with install flag for helm apps
This reverts commit 07d207b.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.