Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: graceful shutdown #127

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

feat: graceful shutdown #127

wants to merge 13 commits into from

Conversation

ShashwatDadhich
Copy link
Contributor

Description

Added the graceful shutdown

Fixes #

How Has This Been Tested?

  • Tested locally
  • Tested by deploying in VM.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.Versions upgrade for libararies

go.mod Outdated
@@ -6,7 +6,7 @@ require (
github.com/argoproj/gitops-engine v0.7.1-0.20231013183858-f15cf615b814
github.com/aws/aws-sdk-go v1.44.285
github.com/caarlos0/env v3.5.0+incompatible
github.com/devtron-labs/common-lib v0.0.16-0.20240221120506-7bc523a23407
github.com/devtron-labs/common-lib v0.0.16-0.20240318063710-69cb957d019a

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check the latest version and import that

@ShashwatDadhich ShashwatDadhich dismissed kripanshdevtron’s stale review April 21, 2024 15:27

The merge-base changed after approval.

Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants