-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Ansible Lightspeed #32
Conversation
Signed-off-by: Valeriy Svydenko <[email protected]>
Signed-off-by: Valeriy Svydenko <[email protected]>
@ibuziuk @dmytro-ndp could you please take a look |
@svor : I have tested PR on https://devspaces.apps.sandbox-stage.gb17.p1.openshiftapps.com/ using factory URL https://github.com/devspaces-samples/ansible-devspaces-demo/tree/sv-enable-lightspeed I can confirm that I was able to connect to "Ansible Lightspeed" service without the problem without additional modification of VS Code Editor settings, even though it was not enabled in the And the same result was on workspaces.openshift.com: Good job, @svor ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to merge
"ansible.lightspeed.suggestions.enabled": true, | ||
"ansible.lightspeed.enabled": true | ||
}, | ||
"folders": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we remove folders at all?
Just not to hardcode /projects
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
folders
block will be added automatically when workspace is created and we'll have unstashed changes in the workspace
Add .code-workspace file with settings to enable Ansible Lightspeed automatically.
Related issue: https://issues.redhat.com/browse/CRW-6336
How to test:
1/ Create a workspace using
2/ When the workspace is started and Ansible extension is initialized, Ansible Lightspeed should be enabled and it should be ready to connect to the server
It's not possible to do this via .vscode/settings.json file because Ansible extension doesn't apply
ansible.lightspeed.enabled
settings that was set on Workspace Folder level. Here is the corresponding issue: ansible/vscode-ansible#1443