Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Ansible Lightspeed #32

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Enable Ansible Lightspeed #32

merged 2 commits into from
Jul 24, 2024

Conversation

svor
Copy link
Collaborator

@svor svor commented Jul 23, 2024

Add .code-workspace file with settings to enable Ansible Lightspeed automatically.

screenshot-nimbusweb me-2024 07 23-12_51_21

Related issue: https://issues.redhat.com/browse/CRW-6336

How to test:
1/ Create a workspace using
Contribute
2/ When the workspace is started and Ansible extension is initialized, Ansible Lightspeed should be enabled and it should be ready to connect to the server

It's not possible to do this via .vscode/settings.json file because Ansible extension doesn't apply ansible.lightspeed.enabled settings that was set on Workspace Folder level. Here is the corresponding issue: ansible/vscode-ansible#1443

@svor svor self-assigned this Jul 23, 2024
@svor
Copy link
Collaborator Author

svor commented Jul 23, 2024

@ibuziuk @dmytro-ndp could you please take a look

@dmytro-ndp
Copy link

dmytro-ndp commented Jul 23, 2024

@svor : I have tested PR on https://devspaces.apps.sandbox-stage.gb17.p1.openshiftapps.com/ using factory URL https://github.com/devspaces-samples/ansible-devspaces-demo/tree/sv-enable-lightspeed

I can confirm that I was able to connect to "Ansible Lightspeed" service without the problem without additional modification of VS Code Editor settings, even though it was not enabled in the Settings > Ansible extenstion > Ansible Lightspeed
Screenshot from 2024-07-23 15-32-39

And the same result was on workspaces.openshift.com:
ansible-workspaces openshift com

Good job, @svor !

Copy link

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to merge

"ansible.lightspeed.suggestions.enabled": true,
"ansible.lightspeed.enabled": true
},
"folders": [

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we remove folders at all?
Just not to hardcode /projects here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

folders block will be added automatically when workspace is created and we'll have unstashed changes in the workspace

@svor svor merged commit 3feae08 into devspaces-3-rhel-8 Jul 24, 2024
1 check passed
@svor svor deleted the sv-enable-lightspeed branch July 24, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants