Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include defaults when describing topics #184

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

rafiramadhana
Copy link
Contributor

@rafiramadhana rafiramadhana commented Jan 14, 2024

Description

Add --include-defaults flag when describing topics

kafkactl@sk-run-pod:~$ kafkactl describe topic topic-1 --output wide --include-defaults

I haven't done any integration test, but unit test run fine:

➜  kafkactl git:(177-describe-default-config) ✗ make test
fatal: No names found, cannot describe anything.
rm -f test.log
go test -v -short ./...
?   	github.com/deviceinsight/kafkactl	[no test files]
=== RUN   TestEnvironmentVariableLoading
--- PASS: TestEnvironmentVariableLoading (0.00s)

...

ok  	github.com/deviceinsight/kafkactl/util	(cached)

Fixes #177

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Documentation

  • the change is mentioned in the ## [Unreleased] section of CHANGELOG.md
  • the configuration yaml was changed and the example config in README.md was updated
  • a usage example was added to README.md
  • tests for the changes have been implemented (see: Testing your changes)

Add include defaults config when describing topics.
@rafiramadhana rafiramadhana changed the title Add include defaults Add include defaults when describing topics Jan 14, 2024
Copy link

@mwarkentin mwarkentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much of a Go programmer, but with that in mind it seems good to me! :)

The tests seem to cover the new cases well.

@d-rk d-rk force-pushed the 177-describe-default-config branch from ff82d92 to 529b639 Compare January 16, 2024 15:25
@d-rk
Copy link
Collaborator

d-rk commented Jan 16, 2024

Hey @rafiramadhana
thank you for the PR 💯 . I reworked it a little so that there is only one parameter needed to control the "printConfigs".

I will try to build a release including this (and some other stuff) by the end of the week.

Cheers,
D.rk

@d-rk d-rk merged commit 0ac3c55 into deviceinsight:main Jan 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support describing all config values in a topic (including defaults)
3 participants