use a better default for replication-factor when creating a new topic (…

…fixes #180)
deviceinsight · Jan 18, 2024 · 88aeec3 · 88aeec3
1 parent b1b2757
commit 88aeec3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - [#184](https://github.com/deviceinsight/kafkactl/pull/184) Added option to show default configs when describing topics
 - [#183](https://github.com/deviceinsight/kafkactl/issues/183) Add command `delete records` to delete records from topic
 
+### Changed
+- [#180](https://github.com/deviceinsight/kafkactl/issues/180) Change default for replication-factor when creating topics
+
 ## 3.5.1 - 2023-11-10
 
 ## 3.5.0 - 2023-11-10

diff --git a/cmd/create/create-topic.go b/cmd/create/create-topic.go
@@ -25,7 +25,7 @@ func newCreateTopicCmd() *cobra.Command {
 	}
 
 	cmdCreateTopic.Flags().Int32VarP(&flags.Partitions, "partitions", "p", 1, "number of partitions")
-	cmdCreateTopic.Flags().Int16VarP(&flags.ReplicationFactor, "replication-factor", "r", 1, "replication factor")
+	cmdCreateTopic.Flags().Int16VarP(&flags.ReplicationFactor, "replication-factor", "r", -1, "replication factor")
 	cmdCreateTopic.Flags().BoolVarP(&flags.ValidateOnly, "validate-only", "v", false, "validate only")
 	cmdCreateTopic.Flags().StringArrayVarP(&flags.Configs, "config", "c", flags.Configs, "configs in format `key=value`")