Skip to content
This repository has been archived by the owner on Feb 22, 2024. It is now read-only.

[WIP] add markdown support for comments, assignments and mardown files #391

Merged
merged 44 commits into from
Jun 15, 2016

Conversation

DouweKoopmans
Copy link
Contributor

fixes #149

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 57.127% when pulling bb98ba9 on MarkdownRendering into 546ac57 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 57.127% when pulling bb98ba9 on MarkdownRendering into 546ac57 on master.

@DouweKoopmans DouweKoopmans changed the title add markdown support for comments, assignments and mardown files [WIP] add markdown support for comments, assignments and mardown files Jun 3, 2016
@DouweKoopmans
Copy link
Contributor Author

don't know why coveralls says the coverage went up, i haven't written any tests yet

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 57.041% when pulling cb13d41 on MarkdownRendering into 546ac57 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 57.1% when pulling 63cdf9f on MarkdownRendering into 546ac57 on master.

@jwgmeligmeyling jwgmeligmeyling added this to the 3.3.0 milestone Jun 5, 2016
@jwgmeligmeyling jwgmeligmeyling self-assigned this Jun 5, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 57.042% when pulling 274ae7e on MarkdownRendering into 546ac57 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 56.966% when pulling e53554c on MarkdownRendering into 546ac57 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 57.051% when pulling 7335de6 on MarkdownRendering into 70e815a on master.

@DouweKoopmans DouweKoopmans changed the title [WIP] add markdown support for comments, assignments and mardown files add markdown support for comments, assignments and mardown files Jun 8, 2016
Fastjur and others added 12 commits June 12, 2016 22:38
These still fail as it requires a git-server update.
Also commented out a faulty test that needs a git-server update before working.
Might be a bit long...
Default behaviour was to expect 3 columns, however when there is a comment this is only one.
Tests emojis (and implicitly thus normal comments)
This ensures they are rendered correctly in every browser.

Make sure to run `mvn generate-resources && mvn compile`
@DouweKoopmans
Copy link
Contributor Author

unfortunately quotation marks are being escaped, so this creates weird output when working with java strings.

@jwgmeligmeyling
Copy link
Member

Ah thats a shame... Maybe we should fix Pegdown?

Fastjur and others added 4 commits June 14, 2016 19:58
@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 56.896% when pulling badcd96 on MarkdownRendering into 70e815a on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 57.517% when pulling c5f5f23 on MarkdownRendering into 70e815a on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 57.753% when pulling 8e454b3 on MarkdownRendering into 70e815a on master.

@jwgmeligmeyling jwgmeligmeyling merged commit 8e454b3 into master Jun 15, 2016
@jwgmeligmeyling jwgmeligmeyling deleted the MarkdownRendering branch June 26, 2016 10:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown for comments, assignments, md files in repo
4 participants