This repository has been archived by the owner on Feb 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
[WIP] add markdown support for comments, assignments and mardown files #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when viewing files in a project, if a file ends with .md (the markdown extention) instead of rendering the raw lines it renders the processed markdown
DouweKoopmans
changed the title
add markdown support for comments, assignments and mardown files
[WIP] add markdown support for comments, assignments and mardown files
Jun 3, 2016
don't know why coveralls says the coverage went up, i haven't written any tests yet |
DouweKoopmans
changed the title
[WIP] add markdown support for comments, assignments and mardown files
add markdown support for comments, assignments and mardown files
Jun 8, 2016
These still fail as it requires a git-server update.
Also commented out a faulty test that needs a git-server update before working.
Sorry for that...
Might be a bit long...
Default behaviour was to expect 3 columns, however when there is a comment this is only one.
Tests emojis (and implicitly thus normal comments)
This ensures they are rendered correctly in every browser. Make sure to run `mvn generate-resources && mvn compile`
unfortunately quotation marks are being escaped, so this creates weird output when working with java strings. |
Ah thats a shame... Maybe we should fix Pegdown? |
added simple test agaisnt xss attacks also update some local variables to use DI for the MarkDownParser instance.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #149