Skip to content

Commit

Permalink
[CPP, Typescript-Node] - Ubuntu-24.04 (noble) & 22-bookworm - updated (
Browse files Browse the repository at this point in the history
…#256)

* [CPP, Typescript-Node] - Ubuntu-24.04 (noble) & 22-bookworm - updated

* more changes

* more changes

* misc change

* fileext change to js

* changes for comments ( review comments on PR )

* misc change

* changes as mentioned in comment
  • Loading branch information
gauravsaini04 authored May 17, 2024
1 parent d9a7063 commit 09c2e4a
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 31 deletions.
5 changes: 3 additions & 2 deletions src/cpp-mariadb/devcontainer-template.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "cpp-mariadb",
"version": "2.1.0",
"version": "2.2.0",
"name": "C++ & MariaDB",
"description": "Develop C++ applications on Linux. Includes Debian C++ build tools.",
"documentationURL": "https://github.com/devcontainers/templates/tree/main/src/cpp-mariadb",
Expand All @@ -9,11 +9,12 @@
"options": {
"imageVariant": {
"type": "string",
"description": "Debian / Ubuntu version (use Debian 12, Debian 11, Ubuntu 22.04 on local arm64/Apple Silicon):",
"description": "Debian / Ubuntu version (use Debian 12, Debian 11, Ubuntu 24.04, and Ubuntu 22.04 on local arm64/Apple Silicon):",
"proposals": [
"debian-12",
"debian-11",
"debian-10",
"ubuntu-24.04",
"ubuntu-22.04",
"ubuntu-20.04"
],
Expand Down
5 changes: 3 additions & 2 deletions src/cpp/devcontainer-template.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "cpp",
"version": "2.1.0",
"version": "2.2.0",
"name": "C++",
"description": "Develop C++ applications on Linux. Includes Debian C++ build tools.",
"documentationURL": "https://github.com/devcontainers/templates/tree/main/src/cpp",
Expand All @@ -9,11 +9,12 @@
"options": {
"imageVariant": {
"type": "string",
"description": "Debian / Ubuntu version (use Debian 12, Debian 11, Ubuntu 22.04 on local arm64/Apple Silicon):",
"description": "Debian / Ubuntu version (use Debian 12, Debian 11, Ubuntu 24.04, and Ubuntu 22.04 on local arm64/Apple Silicon):",
"proposals": [
"debian-12",
"debian-11",
"debian-10",
"ubuntu-24.04",
"ubuntu-22.04",
"ubuntu-20.04"
],
Expand Down
6 changes: 4 additions & 2 deletions src/typescript-node/devcontainer-template.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "typescript-node",
"version": "3.1.0",
"version": "3.2.0",
"name": "Node.js & TypeScript",
"description": "Develop Node.js based applications in TypeScript. Includes Node.js, eslint, nvm, yarn, and the TypeScript compiler.",
"documentationURL": "https://github.com/devcontainers/templates/tree/main/src/typescript-node",
Expand All @@ -11,14 +11,16 @@
"type": "string",
"description": "Node.js version (use -bookworm, -bullseye variants on local arm64/Apple Silicon):",
"proposals": [
"22-bookworm",
"22-bullseye",
"20-bookworm",
"18-bookworm",
"20-bullseye",
"18-bullseye",
"20-buster",
"18-buster"
],
"default": "20-bullseye"
"default": "22-bookworm"
}
},
"platforms": [
Expand Down
24 changes: 0 additions & 24 deletions test/typescript-node/.eslintrc.json

This file was deleted.

11 changes: 11 additions & 0 deletions test/typescript-node/eslint.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
module.exports={
"rules": {
"no-console": 0,
"eqeqeq":"warn",
"no-cond-assign": 0,
"no-unused-vars": 1,
"no-extra-semi": "warn",
"semi": "warn"
},
ignorePatterns: ["**/node_modules/**"]
};
2 changes: 1 addition & 1 deletion test/typescript-node/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ check "node" node --version
sudo rm -f yarn.lock
check "yarn" yarn install
sudo rm -f package-lock.json
check "eslint" eslint --no-eslintrc -c .eslintrc.json src/server.ts
check "eslint" eslint --no-warn-ignored src/server.ts
check "typescript" npm run compile
check "test-project" npm run test
npm config delete prefix
Expand Down

0 comments on commit 09c2e4a

Please sign in to comment.