-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overwrite parent calendar name #394
Open
moritz-schuessler
wants to merge
3
commits into
derekantrican:master
Choose a base branch
from
moritz-schuessler:overwrite-parent-calendar-name
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -205,7 +205,6 @@ function parseResponses(responses){ | |
var result = []; | ||
for (var itm of responses){ | ||
var resp = itm[0]; | ||
var colorId = itm[1]; | ||
var jcalData = ICAL.parse(resp); | ||
var component = new ICAL.Component(jcalData); | ||
|
||
|
@@ -215,13 +214,15 @@ function parseResponses(responses){ | |
ICAL.TimezoneService.register(tz); | ||
} | ||
|
||
var colorId = itm[1] && itm[1].colorId | ||
var allEvents = component.getAllSubcomponents("vevent"); | ||
if (colorId != undefined) | ||
allEvents.forEach(function(event){event.addPropertyWithValue("color", colorId);}); | ||
|
||
var calName = component.getFirstPropertyValue("x-wr-calname") || component.getFirstPropertyValue("name"); | ||
if (calName != null) | ||
allEvents.forEach(function(event){event.addPropertyWithValue("parentCal", calName); }); | ||
var calName = (itm[1] && itm[1].calendarName) || component.getFirstPropertyValue("x-wr-calname") || component.getFirstPropertyValue("name"); | ||
if (calName != null) { | ||
component.getAllSubcomponents("vevent").forEach(function(event){event.addPropertyWithValue("parentCal", calName); }); | ||
} | ||
Comment on lines
+217
to
+225
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In preparation of future changes, let's make this less 'hardcoded'.
|
||
|
||
result = [].concat(allEvents, result); | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use proper ical property names here:
colorId -> color
calendarName -> name
https://www.rfc-editor.org/rfc/rfc5545
https://www.rfc-editor.org/rfc/rfc7986
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need to change 2x parentCal to name at line 460++