Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): set napi object property properly #26344

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix(cli): set napi object property properly #26344

merged 1 commit into from
Oct 17, 2024
+69 −14

Conversation

Brooooooklyn
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@devsnek devsnek merged commit 5689585 into denoland:main Oct 17, 2024
17 checks passed
@Brooooooklyn Brooooooklyn deleted the fix-napi-object-property branch October 17, 2024 14:54
bartlomieju pushed a commit that referenced this pull request Oct 17, 2024
@Brooooooklyn @bartlomieju
fix(cli): set napi object property properly (#26344)
30e085c 
<!--
Before submitting a PR, please read
https://docs.deno.com/runtime/manual/references/contributing

1. Give the PR a descriptive title.

  Examples of good title:
    - fix(std/http): Fix race condition in server
    - docs(console): Update docstrings
    - feat(doc): Handle nested reexports

  Examples of bad title:
    - fix #7123
    - update docs
    - fix bugs

2. Ensure there is a related issue and it is referenced in the PR text.
3. Ensure there are tests that cover the changes.
4. Ensure `cargo test` passes.
5. Ensure `./tools/format.js` passes without changing files.
6. Ensure `./tools/lint.js` passes.
7. Open as a draft PR if your work is still in progress. The CI won't
run
   all steps, but you can add '[ci]' to a commit message to force it to.
8. If you would like to run the benchmarks on the CI, add the 'ci-bench'
label.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsnek devsnek devsnek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Brooooooklyn @CLAassistant @devsnek