Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for customising 'recent' group icon #74

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fearistoff
Copy link

Context

Adding customising options for 'recent' group icon.

Summary

Because decomposing state.options.groupIcons is placed before recent field, component prop group-icons have no access to change Recent group icon.

Relevant Technical Choices

By switching those lines it now available to change.

User-facing changes

In both screenshots to component's code:

<picker :native="false" :display-recent="true" @select="onSelect" :group-icons="{ recent: 'https://www.svgrepo.com/show/172818/star-outline.svg'}" />
Before After
image image

Checklist

  • I have tested this code to the best of my abilities
  • I have added documentation where necessary

Copy link

codesandbox bot commented Jun 18, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant