This repository has been archived by the owner on Jun 26, 2021. It is now read-only.
New metric calculation #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justusschock
added
new feature
…k (add init arguments and adjust `reinitialize_logging` function)
justusschock
added
ready for review
mibaumgartner
suggested changes
Sep 11, 2019
There was a problem hiding this comment.
After merging #201 we could easily add a test to check for execution of the iter callback. The rest looks good to go.
…ictor iter callback fix, default logging callback fix
… into new_metric_calculation
… into new_metric_calculation
mibaumgartner
approved these changes
Sep 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to unify metric calculation for testing and training. This is done by moving the metric calculation outside the
closure.This PR includes breaking changes
This PR should be merged once #102 is merged
Since the topics are related, I integrated the PR #175 in here.