-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Kubernetes Client to 6.8.0 #1233
Bump Kubernetes Client to 6.8.0 #1233
Conversation
@manusa: I think that we should definitely update both at the same time. |
I am a bit worried though about the impact that this will have downstream. |
I also bootstrapped the Quarkus PR (quarkusio/quarkus#34956) to keep track of anything. I don't think there's any rush, so we can work on this with calm. At the moment I can't look into the Sundrio problem. If there are no more updates, I'll try to look into it at the end of the week. |
At closer inspection: Using something like:
fixes things. Unfortunately, this needs to be added pretty much to all modules, which is lot of work. I've been pondering for a while an alternative mechanism of detecting buildables and via class lookup (e.g. if there is an XXXFluent.class and XXXBuilder.class, then XXX is buildable). Maybe its time to put it to the test. |
ae4f74e
to
db9c06a
Compare
I added the BuildableReferences which seems to take care of the problem. |
This is definitely needed before we update the client in Quarkus as this is causing errors downstream as seen in https://github.com/quarkiverse/quarkus-operator-sdk/actions/runs/5779716289/job/15662390642#step:8:3612 for example. |
db9c06a
to
1ec63de
Compare
It's compiling locally now |
Not sure if this is due to the change in the Sundrio Builders, annotations, or anything else. However, the S2i built image is not able to run the artifact. The jar file doesn't contain a manifest main attribute and is not able to launch the jar file. The fabric8/s2i-java image does include stuff to explode a Spring Boot Jar file and infer the BOOT-INF information, however this isn't present either in the Jar artifact. So I'm assuming that there must be a problem with whatever logic you have in place to determine what's the main class (I've seen the SpringBootApplicationXxx classes have something there) and the new sundrio generated Pojos and builders. |
deps: Bump sundrio to 0.100.3
As discussed internally, the current behavior is OK. Some of the OpenShift integration tests aren't fine, this is why they are flaky at the moment.
If the OpenShiftExtension detects the "Readiness" then the tests will pass. dekorate/testing/openshift-junit/src/main/java/io/dekorate/testing/openshift/OpenshiftExtension.java Lines 198 to 199 in ffbdb0c
If, however, the client doesn't detect the brief readiness, the test preparation will throw an exception and the test will fail. dekorate/testing/openshift-junit/src/main/java/io/dekorate/testing/openshift/OpenshiftExtension.java Lines 203 to 214 in ffbdb0c
As agreed, I'll add a further commit to fix the test artifacts that aren't OK. |
1ec63de
to
34c3f66
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
The new failure looks more like just a flake. Seems that the OpenShift S2I build timed out for whatever reason (maybe not enough resources) Same test run locally completes successfully:
@iocanel Could you please re-trigger the pipeline? |
@iocanel what's preventing this from being merged? |
Mostly, that I am on vacation. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry, it wasn't in any of our shared calendars… |
Prior to bumping the Kubernetes Client version in Quarkus, we need to align the Fabric8 Kubernetes Client in Dekorate.
I'm trying to update. However, I'm reaching two problems (for now):
@Pojo
generator. I think that since it has a Buildable superClass (in this case Configuration) the template uses agetXxx
method which is not OK. My impression is that the problem is in Sundrio and that this wasn't considered when removing the Fluent interfaces (the Pojo tests don't include this scenario)I'm kind of blocked at the moment.
/cc @iocanel