This repository has been archived by the owner on Oct 10, 2021. It is now read-only.
add basic browserstack support #126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,6 +22,7 @@ program | |||
| .option('--local [port]', 'port for manual testing in a local browser') | |||
| .option('--tunnel', 'establish a tunnel for outside access. only used when --local is specified') | |||
| .option('--phantom', 'run tests in phantomjs. PhantomJS must be installed separately.') | |||
| .option('--browserstack', 'run tests in BrowserStack instead of Sauce Labs.') | |||
There was a problem hiding this comment.
wondering if --platform <sauce | browserstack | phantom > wouldn't be a better flag
There was a problem hiding this comment.
I like the --platform flag. Unlikely confused with --browser-platform.
|
@yanatan16 any updates on this? Anything I can do to help? :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basic BrowserStack support. It does
--list-available-browsersand runs tests when--browserstackis passed in. It requiresbrowserstack_usernameandbrowserstack_keyvalues in.zuulrc.Known Bugs:
See #124