Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example Tagging Release #481

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

dvonthenen
Copy link
Contributor

@dvonthenen dvonthenen commented Nov 4, 2024

Proposed changes

Document actual git commands for performing a release.

Types of changes

What types of changes does your code introduce to the community Python SDK?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have lint'ed all of my code using repo standards
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Summary by CodeRabbit

  • Documentation
    • Updated the release process documentation to include a new section on "Creating a Release."
    • Added a subsection detailing the procedure for creating releases from specific release branches.

Copy link
Contributor

coderabbitai bot commented Nov 4, 2024

Walkthrough

The pull request introduces updates to the .github/BRANCH_AND_RELEASE_PROCESS.md document, adding a new section titled "Creating a Release" which details the steps for creating a release within the GitHub Flow branching strategy. It includes instructions for users with write access, focusing on Git tags and drafting releases. Additionally, a subsection on "Creating a Release from a Release Branch" is added, outlining procedures for patch releases from specific branches, including example commands for clarity.

Changes

File Change Summary
.github/BRANCH_AND_RELEASE_PROCESS.md Added a new section "Creating a Release" and a subsection "Creating a Release from a Release Branch" with detailed instructions and example commands.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Outside diff range and nitpick comments (3)
.github/BRANCH_AND_RELEASE_PROCESS.md (3)

105-106: Fix inconsistent spacing in git push command.

There's a double space in the command git push upstream <version>.

-git push upstream  <version>
+git push upstream <version>

96-107: Enhance command documentation with step explanations.

While the commands are correct, adding brief comments explaining each step's purpose would improve clarity for users unfamiliar with git.

 ```bash
 # get the latest everything and update your fork
 git checkout main
-git pull --rebase upstream main
-git push
-git fetch upstream --tags
-git push origin --tags
+git pull --rebase upstream main    # Update local main with upstream changes
+git push                          # Update your fork's main branch
+git fetch upstream --tags         # Fetch all tags from upstream
+git push origin --tags           # Sync tags to your fork
 
 # create a new tag following semver
-git tag -m <version> <version>
-git push upstream  <version>
+git tag -m <version> <version>    # Create an annotated tag locally
+git push upstream <version>       # Push the new tag to upstream

124-128: Clarify when to use release branch process.

While the document mentions security fixes as an example, it would be helpful to provide more specific guidance about when to use this process versus creating a release from main.

Consider adding a list of scenarios:

Common scenarios for creating releases from a release branch:
- Critical security vulnerabilities requiring immediate patches
- Customer-specific hotfixes for older supported versions
- Compatibility fixes for specific SDK versions
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between aff6110 and 9857dae.

📒 Files selected for processing (1)
  • .github/BRANCH_AND_RELEASE_PROCESS.md (1 hunks)

.github/BRANCH_AND_RELEASE_PROCESS.md Show resolved Hide resolved
.github/BRANCH_AND_RELEASE_PROCESS.md Show resolved Hide resolved
@dvonthenen dvonthenen merged commit d3bb649 into deepgram:main Nov 5, 2024
4 checks passed
@dvonthenen dvonthenen deleted the example-tag-release branch November 5, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants