Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeUtteranceEndResponse & handle case in live.router #147

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

boyswan
Copy link
Contributor

@boyswan boyswan commented Dec 18, 2023

Proposed changes

Reference: #146

Types of changes

What types of changes does your code introduce to the community Go SDK?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

pkg/api/live/v1/router.go Show resolved Hide resolved
pkg/api/live/v1/interfaces/interfaces.go Outdated Show resolved Hide resolved
pkg/api/live/v1/default.go Outdated Show resolved Hide resolved
pkg/api/live/v1/router.go Outdated Show resolved Hide resolved
@dvonthenen
Copy link
Contributor

Thanks for the update. I'll take a look at this in a little bit! I super appreciate it!

@dvonthenen
Copy link
Contributor

dvonthenen commented Dec 21, 2023

Hey @boyswan, these changes look great! Thanks a lot for your help on this! Really appreciate the contribution!

@dvonthenen dvonthenen merged commit 843e1e0 into deepgram:main Dec 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants