Review of Structs Naming Convention + Callback Processing Example #127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Changes:
callback
processing found here: https://developers.deepgram.com/docs/callback/omitempty
to all nodes in struct in the event that there are times in which certain fields aren't required. This solves any issues with JSON parsing and gives best-effort return on valuesResult_id
toResultID
to fix issues with Go naming conventions. Do this for all the names. This will trigger errors when we add the linter for Go.Summary
object is. This is an attempt to keep both definitions to maintain backwards compatibility within the SDK.Types of changes
What types of changes does your code introduce to the community Go SDK?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
NA