HotFix for SetTimeout() having no effect #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed .HttpClient.Create() in HttpCLientUtil.SetTimeOut(TimeSpan timeSpan)
|
Please get this released ASAP. This bug is costing me money |
|
As I mentioned here: I am just coming on board to the project and will be taking a look at this today along with other .NET related stuff. From a quick glance, it looks like it isn't much of a fix but more trying to undo a mistake. We need to verify and perform due diligence before committing any changes to prevent any unintended consequences of the change. If you rollback to .NET v3.1.0 that should remove the timeout functionality and get you going again. |
|
This PR #207 has been merged and released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #127 ("A customer reported that it's not possible to set the HTTP Timeout at all now.")
See this comment for the idea to this pull request.
Problem:
deepgram.SetHttpClientTimeout(...) has no effect.
Hotfix:
removed .HttpClient.Create() in HttpClientUtil.SetTimeOut(TimeSpan timeSpan)