Fixing HttpException when using Float url parameters with fractional values #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added culture invariant ToString
dvonthenen
approved these changes
Jan 24, 2024
|
thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #177 ("Specifiying UtteranceSplit parameter with a fractional value causes HttpException")
When calling
DeepgramClient.Transcription.Prerecorded.GetTranscriptionAsync(...)with aPrerecordedTranscriptionOptionsparameter that contains aPrerecordedTranscriptionOptions.UtteranceSplitvalue which has a fractiuonal value (i.e. 1.2, 2.5) causes HttpException. Values like 2.0, 1.0 do not cause exception.The issue is the way the float value is being serialized in
Deepgram.Utilities.QueryParameterUtil.GetParameters(...)A parameter value of 2.2
is serialized into this url parameter: utt_split=2%2c2
I added a "Float" type branch in
Deepgram.Utilities.QueryParameterUtil.GetParameters(...)which does not url encode the float value and stringifies it with an invariant culture.