addrmgr: Track network types and remove TorV2 support #3406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthawkins90
force-pushed
the
addrmgr_types
branch
from
c338f5e
to
42b8952
Compare
davecgh
reviewed
Jul 16, 2024
davecgh
requested changes
Jul 17, 2024
This commit adds support for determining and tracking the type of a network address when constructed. While here, several functions are refactored for easier reading and interpretability. The types are first defined in network.go, and then constructed in netaddress.go. The rest of the changes propagate outward from there. Minimal changes were made to anything related to TorV2, because it will be removed in a future commit.
matthawkins90
force-pushed
the
addrmgr_types
branch
2 times, most recently
from
6ccac1f
to
9e40429
Compare
This commit creates two new functions: EncodeHost and NewNetAddressFromParams. The goal is to allow easier creation of net addresses without needing to resort to DNS lookups. DNS lookups will be removed from addrmgr.
matthawkins90
force-pushed
the
addrmgr_types
branch
from
9e40429
to
b085d66
Compare
davecgh
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This heavily references the work started in #2627. However, the work will be broken out into smaller chunks. Ultimately, the goal in the near future is to refactor Addrmgr to remove TorV2 support, and add support for TorV3. However, this PR doesn't include any TorV3 work yet.
The first commit enables tracking of address types, and includes several function refactors to improve readability. The new types are defined in
network.go, and then constructed innetaddress.go. The rest of the changes propagate outward from there.The second commit removes TorV2 support.
The third commit adds new functions:
ParseHostandNewNetAddressFromParams. These functions will eventually enable two desirable features: