multi: Reduce done goroutines. #3199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
multi_reduce_done_goroutines
branch
from
6146600
to
af8311b
Compare
jholdstock
reviewed
Oct 25, 2023
jrick
approved these changes
Oct 25, 2023
This modifies the logic in several Run methods to block until the context is cancelled directly in the Run method instead of launching a separate goroutine for that purpose. This approach is preferred since it provides the same functionality without additional long-running goroutines.
davecgh
force-pushed
the
multi_reduce_done_goroutines
branch
from
af8311b
to
ae64e51
Compare
jholdstock
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the logic in several Run methods to block until the context is cancelled directly in the Run method instead of launching a separate goroutine for that purpose.
This approach is preferred since it provides the same functionality without additional long-running goroutines.