[release-v1.8] main: Use backported rpc types updates. #3192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the 1.8 release to use the latest version of the rpc/jsonrpc/types module which includes updates to expose the new proof of work hash in the verbose getblock and getblockheader results. In particular, the following updated module version is used: - github.com/decred/dcrd/rpc/jsonrpc/types/[email protected]
alexlyp
approved these changes
Sep 27, 2023
|
This only changes the types, it doesn't backport the changes to the rpc method handlers that populate the fields? |
Aye, I noticed that and was in the process of updating. It should be good to go now. |
davecgh
added
the
rpc server api change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the 1.8 release to use the latest version of the
rpc/jsonrpc/typesmodule which includes updates to expose the new proof of work hash in the verbosegetblockandgetblockheaderresults.In particular, the following updated module version is used:
Note that it also cherry picks all of the commits included in updates to the
rpc/jsonrpc/types/v4module to ensure they are also included in the release branch even though it is not strictly necessary since thego.modhas been updated to require the newrpc/jsonrpc/types/v4.1.0release and thus will pull in the new code. However, from past experience, not having code backported to modules available in the release branch too leads to headaches for devs building from source in their local workspace with overrides such as those ingo.work.