dcrec/secp256k1: update error types. #2265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
force-pushed
the
update_secp256k1_error_types
branch
from
5c877ac
to
fca912c
Compare
dnldd
commented
Jul 15, 2020
dnldd
force-pushed
the
update_secp256k1_error_types
branch
from
fca912c
to
3517d4f
Compare
dnldd
force-pushed
the
update_secp256k1_error_types
branch
from
3517d4f
to
3dbcd11
Compare
This updates the secp256k1 error types to leverage go 1.13 errors.Is/As functionality as well as confirm to the error infrastructure best practices.
dnldd
force-pushed
the
update_secp256k1_error_types
branch
from
3dbcd11
to
ff748ba
Compare
davecgh
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the sec256k1 error types to leverage go 1.13 errors.Is/As functionality as well as confirm to the error infrastructure best practices outlined in #2181.