gcs: update error types. #2262
Merged
gcs: update error types. #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
force-pushed
the
update_gcs_error_types
branch
from
6adf076
to
dd8e213
Compare
dnldd
force-pushed
the
update_gcs_error_types
branch
from
dd8e213
to
f22ff25
Compare
davecgh
requested changes
Nov 4, 2020
There was a problem hiding this comment.
This is changing the public API in a non-backwards compatible way. That means a major module version bump is required. Please follow the standard practice for a major version bump to v3. It should probably be in a separate PR, but at the very least a separate commit before these changes are made.
dnldd
force-pushed
the
update_gcs_error_types
branch
from
f22ff25
to
051bb9f
Compare
|
Needs rebase and to bump the |
davecgh
requested changes
Nov 11, 2020
This updates the gcs error types to leverage go 1.13 errors.Is/As functionality as well as confirm to the error infrastructure best practices.
dnldd
force-pushed
the
update_gcs_error_types
branch
from
051bb9f
to
b539450
Compare
davecgh
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #2463
This updates the gcs error types to leverage go 1.13 errors.Is/As functionality as well as confirm to the error infrastructure best practices outlined in #2181.