-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcs: update error types. #2262
gcs: update error types. #2262
Conversation
6adf076
to
dd8e213
Compare
dd8e213
to
f22ff25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is changing the public API in a non-backwards compatible way. That means a major module version bump is required. Please follow the standard practice for a major version bump to v3. It should probably be in a separate PR, but at the very least a separate commit before these changes are made.
f22ff25
to
051bb9f
Compare
Needs rebase and to bump the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Just a few inline comments and the aforementioned need to rebase and update the required Go version in the go.mod
.
This updates the gcs error types to leverage go 1.13 errors.Is/As functionality as well as confirm to the error infrastructure best practices.
051bb9f
to
b539450
Compare
depends on #2463
This updates the gcs error types to leverage go 1.13 errors.Is/As functionality as well as confirm to the error infrastructure best practices outlined in #2181.