Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wake] Feat: add partner token cookie and use in every request that suports It #917

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

IncognitaDev
Copy link
Contributor

What is this Contribution About?

This PR adds function to set and delete partner token cookie and use in every request that suports this token.
This PR also change the partner prop of wake ProductListingPage to make this prop more meaningful

Copy link
Contributor

Tagging Options

Should a new tag be published when this PR is merged?

  • 👍 for Patch 0.62.3 update
  • 🎉 for Minor 0.63.0 update
  • 🚀 for Major 1.0.0 update

wake/loaders/productDetailsPage.ts Outdated Show resolved Hide resolved
shopify/utils/storefront/storefront.graphql.gen.ts Outdated Show resolved Hide resolved
* @description page param to partners page
*/
slug?: RequestURLParam;
partnerAlias?: RequestURLParam;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It brokes the current sites using wake api, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe, but this was added in the last PR of this feature, I think the beyoung and the hive its only stores that uses, and they already is using this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants