Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Blog extensions: Reviews and Ratings #861

Open
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

aka-sacci-ccr
Copy link
Contributor

@aka-sacci-ccr aka-sacci-ccr commented Sep 13, 2024

What is this Contribution About?

With this contribution, it is possible to add extensions to blog loaders.
The two extensions created enable user interactions with posts - Ratings and Reviews

Loom Video

Record a quick screencast describing your changes to help the team understand and review your contribution. This will greatly assist in the review process.

Demonstration Link

Provide a link to a branch or environment where this pull request can be tested and seen in action.

Copy link
Contributor

Tagging Options

Should a new tag be published when this PR is merged?

  • 👍 for Patch 0.59.9 update
  • 🎉 for Minor 0.60.0 update
  • 🚀 for Major 1.0.0 update

@matheusgr
Copy link
Contributor

@aka-sacci-ccr this seems as a big PR / contribution.

Can you describe your intent and the work that is still pending on an issue?

@aka-sacci-ccr aka-sacci-ccr changed the title WIP - Feat blog like WIP - Blog extensions: Reviews and Ratings Sep 30, 2024
@aka-sacci-ccr
Copy link
Contributor Author

aka-sacci-ccr commented Sep 30, 2024

@matheusgr Basically, it's just two extensions in the blog loaders, using deco records to save these interactions.
Btw, this still WIP.
Unfortunately, im having some troubles in running blog/db/schema.ts in the storefront side. Trying to workaround.

): Promise<Review[]> {
const records = await ctx.invoke.records.loaders.drizzle();

const whereClause = ignoreReviews?.active && ignoreReviews?.markedAs &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the name utils for things like: checkIfDateIsBefore, encodeToken.. and not your core business logic.

We don't have something well setup for that, but you'll come up with a good name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants