Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework dependency update #246

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Rework dependency update #246

merged 2 commits into from
Oct 21, 2024

Conversation

nicoecheza
Copy link
Contributor

@nicoecheza nicoecheza commented Oct 17, 2024

closes #236

Test cases:

  1. If project does not have node_modules, running the project will install them
  2. If a project get's externally deleted while the app is open, it should go back to the scenes page and remove the project from the scenes list
  3. If workspace has auto update set on, entering a project with outdated deps, should update them automatically
  4. If workspace has notify set on, entering a project with outdated deps, should notify about them. Clicking on the notification should update the notification
  5. If workspace has "nothing" set on, entering a project with outdated deps, should do nothing

Copy link

Test this pull request on windows-latest

Download the correct version for your architecture:

win-x64

Copy link

github-actions bot commented Oct 17, 2024

Test this pull request on macos-latest

Download the correct version for your architecture:

mac-arm64
mac-x64

Click here if you don't know which version to download

For running this unsigned version of the app, you will need to run the xattr command on it:

  1. Extract the app from the downloaded .dmg file (double-click it)
  2. Place the extracted app anywhere you like in your file system
  3. Open a terminal on the directory where the app is
  4. Run xattr -c app-name, replacing "app-name" for the actual name of the app
  5. Double-click the app ✅

@nicoecheza nicoecheza marked this pull request as ready for review October 18, 2024 15:44
@cazala
Copy link
Member

cazala commented Oct 18, 2024

Changing the strategy on the Settings page does not seem to have an effect until reloading the app. Probably changing the value on the config.json but not on the redux store?

@nicoecheza nicoecheza enabled auto-merge (squash) October 21, 2024 15:43
@nicoecheza nicoecheza merged commit 77a4efb into main Oct 21, 2024
10 checks passed
@nicoecheza nicoecheza deleted the fix/deps-implementation branch October 21, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT]
3 participants