- fix: name and description env

dcSpark · Oct 26, 2023 · f95dde7 · f95dde7
1 parent 9dfc784
commit f95dde7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/release-dev.yml b/.github/workflows/release-dev.yml
@@ -40,6 +40,8 @@ jobs:
         run: npx nx build shinkai-visor --skip-nx-cache --verbose
         env:
           VERSION: 0.0.0.${{github.run_number}}
+          NAME_PREFIX: '[Dev] '
+          DESCRIPTION_PREFIX: 'This is for development purpose.\n\n'
 
       - name: Zip extension
         run: cd ./dist/apps && zip -r shinkai-visor.zip shinkai-visor
@@ -73,8 +75,6 @@ jobs:
           VERSION: 0.0.0
           BUILD: ${{github.run_number}}
           APP_PATH: ./apps/shinkai-app
-          NAME_PREFIX: '[Dev] '
-          DESCRIPTION_PREFIX: 'This is for development purpose.\n\n'
 
       - name: Run NX build on shinkai-app-android
         run: |

diff --git a/apps/shinkai-visor/dynamic-manifest.ts b/apps/shinkai-visor/dynamic-manifest.ts
@@ -12,11 +12,11 @@ const getVersion = () => {
 };
 
 const getName = () => {
-  return `${process.env.NAME_PREFIX}${baseManifestJson.name}`;
+  return `${process.env.NAME_PREFIX || ''}${baseManifestJson.name}`;
 }
 
 const getDescription = () => {
-  return `${process.env.DESCRIPTION_PREFIX}${baseManifestJson.description}`;
+  return `${process.env.DESCRIPTION_PREFIX || ''}${baseManifestJson.description}`;
 }
 
 export const dynamicManifest = defineManifest((env) => {