Fix distorted execution tree in complex queries and jpg download #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issues
Complex queries can generate distorted execution trees, as shown in #197. There is also a bug in the download jpg menu (
Download->Result (JPG)), which only considers the execution tree from the very first tab (Relational Algebra). If another tab is active, the downloaded jpg file is empty.What does this implement/fix?
This PR fixes the distortion problem and adds a modal zoom functionality to ease the tree visualization. It also fixes the download jpg problem so that the tree from the active tab is the one considered.
Distorted tree problem
The query used was the one presented at #197.
JPG download problem
Downloaded file:
Downloaded file:
How to test this PR?
Test it live at https://rlaiola.github.io/relax/calc/local/uibk/local/1