Skip to content

Commit

Permalink
Remove redundant HTTP.start block
Browse files Browse the repository at this point in the history
It looks like only `download_csv_string` does any downloading,
so maybe we can omit the HTTP.start block from `download_csv`?
  • Loading branch information
balvig authored and davidstosik committed Oct 7, 2024
1 parent 3c380e9 commit 923af0c
Showing 1 changed file with 9 additions and 14 deletions.
23 changes: 9 additions & 14 deletions lib/mfynab/money_forward.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,23 +33,18 @@ def get_session_id(username:, password:)
def download_csv(session_id:, path:, months:)
month = Date.today
month -= month.day - 1 # First day of month
months.times do
date_string = month.strftime("%Y-%m")

Net::HTTP.start(base_url.host, use_ssl: true) do |http|
http.response_body_encoding = Encoding::SJIS

months.times do
date_string = month.strftime("%Y-%m")
logger.info("Downloading CSV for #{date_string}")

logger.info("Downloading CSV for #{date_string}")

# FIXME: I don't really need to save the CSV files to disk anymore.
# Maybe just return parsed CSV data?
File.open(File.join(path, "#{date_string}.csv"), "wb") do |file|
file << download_csv_string(date: month, session_id: session_id)
end

month = month.prev_month
# FIXME: I don't really need to save the CSV files to disk anymore.
# Maybe just return parsed CSV data?
File.open(File.join(path, "#{date_string}.csv"), "wb") do |file|
file << download_csv_string(date: month, session_id: session_id)
end

month = month.prev_month
end
end

Expand Down

0 comments on commit 923af0c

Please sign in to comment.