This repository has been archived by the owner on Aug 21, 2018. It is now read-only.
Fix isNumberMatchingDesc method for Windows and other OS #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…L != "\n" Used preg_replace instead of str_replace, search and replace any vertical whitespace character
Stop removing first element from supportedRegions when array_search returns FALSE. Also `unset` replaced by `array_slice` to save a sequence of keys.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix isNumberMatchingDesc method for Windows and other OS where PHP_EOL NOT "\n"
Used preg_replace instead of str_replace, search and replace any vertical whitespace character