add comments before publishing new version

datatheorem · Apr 11, 2018 · b7cd92e · b7cd92e
1 parent 4a6bfa1
commit b7cd92e
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/trustkit/src/main/java/com/datatheorem/android/trustkit/config/DomainPinningPolicy.java b/trustkit/src/main/java/com/datatheorem/android/trustkit/config/DomainPinningPolicy.java
@@ -43,6 +43,8 @@ public final class DomainPinningPolicy {
             throws MalformedURLException {
         // Run some sanity checks on the configuration
         // Check if the hostname seems valid
+        // DomainValidator.getInstance(true) allows TrustKit to include localhost in the valid domains
+        // see https://github.com/datatheorem/TrustKit-Android/issues/25
         DomainValidator domainValidator = DomainValidator.getInstance(true);
         if (!domainValidator.isValid(hostname)) {
             throw new ConfigurationException("Tried to pin an invalid domain: " + hostname);