1. fix

2. add tasks and task_history to SYSTEM_TABLES_ALLOW_LIST 3. delete useless test
databendlabs · May 14, 2024 · ce002e9 · ce002e9
1 parent 350dd50
commit ce002e9
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 10 deletions.
diff --git a/src/query/ast/src/parser/statement.rs b/src/query/ast/src/parser/statement.rs
@@ -2831,7 +2831,7 @@ pub fn priv_type(i: Input) -> IResult<UserPrivilegeType> {
  UserPrivilegeType::CreateDatabase,
  rule! { CREATE ~ DATABASE },
  ),
- value(UserPrivilegeType::CreateDatabase, rule! { CREATE ~ TASK }),
+ value(UserPrivilegeType::CreateTask, rule! { CREATE ~ TASK }),
  value(UserPrivilegeType::DropUser, rule! { DROP ~ USER }),
  value(UserPrivilegeType::CreateRole, rule! { CREATE ~ ROLE }),
  value(UserPrivilegeType::DropRole, rule! { DROP ~ ROLE }),

diff --git a/src/query/service/src/interpreters/access/privilege_access.rs b/src/query/service/src/interpreters/access/privilege_access.rs
@@ -54,7 +54,7 @@ enum ObjectId {
 // some statements like `SELECT 1`, `SHOW USERS`, `SHOW ROLES`, `SHOW TABLES` will be
 // rewritten to the queries on the system tables, we need to skip the privilege check on
 // these tables.
-const SYSTEM_TABLES_ALLOW_LIST: [&str; 18] = [
+const SYSTEM_TABLES_ALLOW_LIST: [&str; 20] = [
  "catalogs",
  "columns",
  "databases",
@@ -73,6 +73,8 @@ const SYSTEM_TABLES_ALLOW_LIST: [&str; 18] = [
  "processes",
  "user_functions",
  "functions",
+ "tasks",
+ "task_history",
 ];
 
 impl PrivilegeAccess {

diff --git a/tests/suites/0_stateless/18_rbac/18_0011_task.result b/tests/suites/0_stateless/18_rbac/18_0011_task.result
diff --git a/tests/suites/0_stateless/18_rbac/18_0011_task.sh b/tests/suites/0_stateless/18_rbac/18_0011_task.sh