Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slice operator #53

Merged
merged 23 commits into from
Jul 7, 2023
Merged

Slice operator #53

merged 23 commits into from
Jul 7, 2023

Conversation

chrishavlin
Copy link
Collaborator

@chrishavlin chrishavlin commented Jun 26, 2023

This PR adds support for adding 2d slices to a napari viewer.

This is a step to supporting #35 for slices and Closes #11

Still to do:

  • handle the ingestion (initial push only includes data model updates)
  • add tests
  • update docs

@chrishavlin chrishavlin added the enhancement New feature or request label Jun 26, 2023
@chrishavlin chrishavlin added this to the v0.2.0 milestone Jun 26, 2023
@chrishavlin chrishavlin marked this pull request as draft June 26, 2023 20:31
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06 🎉

Comparison is base (0eb1719) 99.72% compared to head (9e87f50) 99.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   99.72%   99.79%   +0.06%     
==========================================
  Files          20       24       +4     
  Lines        1106     1452     +346     
==========================================
+ Hits         1103     1449     +346     
  Misses          3        3              
Impacted Files Coverage Δ
src/yt_napari/_tests/test_reader.py 100.00% <ø> (ø)
src/yt_napari/_data_model.py 98.07% <100.00%> (+1.41%) ⬆️
src/yt_napari/_ds_cache.py 100.00% <100.00%> (ø)
src/yt_napari/_gui_utilities.py 100.00% <100.00%> (ø)
src/yt_napari/_model_ingestor.py 100.00% <100.00%> (ø)
src/yt_napari/_reader.py 100.00% <100.00%> (ø)
src/yt_napari/_special_loaders.py 100.00% <100.00%> (ø)
src/yt_napari/_tests/test_gui_utilities.py 100.00% <100.00%> (ø)
src/yt_napari/_tests/test_model_ingestor.py 100.00% <100.00%> (ø)
...t_napari/_tests/test_schema_version_comparisons.py 100.00% <100.00%> (ø)
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chrishavlin chrishavlin modified the milestones: v0.2.0, v0.1.0 Jun 30, 2023
@chrishavlin
Copy link
Collaborator Author

chrishavlin commented Jul 3, 2023

the widget loader now runs. things to fix:

  • set log option by layer
  • pre-sort the selections by domain width to avoid downscaling higher res regions
  • tests (still)
  • define the behavior when adding both slices and regions

@chrishavlin
Copy link
Collaborator Author

chrishavlin commented Jul 3, 2023

layer deletion bug: multiple layers. remove layer 1, cant remove layer > 1 after that. fixed

@chrishavlin chrishavlin linked an issue Jul 5, 2023 that may be closed by this pull request
@chrishavlin
Copy link
Collaborator Author

in terms of functionality, last thing to do is refactor the notebook interface a bit for slicing.

@chrishavlin
Copy link
Collaborator Author

notebook interface (Scene) now refactored. all the functionality is done... just need to improve tests and update docs.

@chrishavlin chrishavlin changed the title [WIP] Slice operator Slice operator Jul 7, 2023
@chrishavlin chrishavlin marked this pull request as ready for review July 7, 2023 16:43
@chrishavlin chrishavlin merged commit 3f4290b into data-exp-lab:main Jul 7, 2023
18 checks passed
@chrishavlin chrishavlin deleted the slice_operator branch July 7, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scaling issue plugin functionality: return 2d image layers from slices
1 participant