Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce typehints in controller #881

Merged

Commits on Apr 30, 2024

  1. General code quality improvements for the controller part of this rep…

    …ository.
    
    Make sure exported symbols are correctly set in __init__.py with __all__.
    Renamed pytest fixture for creating a k8s namespace from ns to namespace since ns is a bit overloaded, especially in test_controller.py
    Introduce typehints in controller.py and test_controller.py to massively improve developer experience (previously, one just really had to guess what functions are for and which types are expected)
    Removed unused function parameters
    Made function headers (i.e. parameter [type] defintion) compatible with what `kopf.on.[create/change/...]' expects
    Introduce mypy (and missing stubs of external packages if available)
    Introduce mypy ignores for (still) untyped parts of the codebase for now
    Jonas Dedden committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    82c1d93 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Introduce mypy section in pyproject.toml, ignore untyped imports and …

    …untyped external calls
    Jonas Dedden committed May 30, 2024
    Configuration menu
    Copy the full SHA
    85c9a0b View commit details
    Browse the repository at this point in the history
  2. Black fixes

    Jonas Dedden committed May 30, 2024
    Configuration menu
    Copy the full SHA
    27750ab View commit details
    Browse the repository at this point in the history