suggestions

dashpay · Nov 1, 2024 · fb58431 · fb58431
1 parent 6b76485
commit fb58431
Showing 1 changed file with 16 additions and 2 deletions.
diff --git a/dash/src/consensus/encode.rs b/dash/src/consensus/encode.rs
@@ -912,12 +912,26 @@ pub fn read_compact_size<R: Read + ?Sized>(r: &mut R) -> io::Result<u32> {
         0xFD => {
             let mut buf = [0u8; 2];
             r.read_exact(&mut buf)?;
-            Ok(u16::from_le_bytes(buf) as u32)
+            let value = u16::from_le_bytes(buf) as u32;
+            if value < 0xFD {
+                return Err(io::Error::new(
+                    io::ErrorKind::InvalidData,
+                    "Non-minimal compact size encoding",
+                ));
+            }
+            Ok(value)
         }
         0xFE => {
             let mut buf = [0u8; 4];
             r.read_exact(&mut buf)?;
-            Ok(u32::from_le_bytes(buf))
+            let value = u32::from_le_bytes(buf);
+            if value <= 0xFFFF {
+                return Err(io::Error::new(
+                    io::ErrorKind::InvalidData,
+                    "Non-minimal compact size encoding",
+                ));
+            }
+            Ok(value)
         }
         0xFF => {
             // Value is too large to fit in u32