docs(dip27): update withdrawal safety to match v22 #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dash Core v22 makes simplifies withdrawal safety rules and also makes them less restrictive
| @@ -142,6 +142,10 @@ Asset Unlock transactions might not be mined for multiple reasons. For example, | |||
| As a way to avoid a catastrophic failure if Platform is compromised, Core will limit credit pool withdrawals for at least the first release of Platform. The withdrawal limits may be re-evaluated and updated periodically as the system matures. To evaluate withdrawal validity, withdrawal amounts from the last 576 blocks should be tallied. The withdrawal should not be mined if: | |||
|
|
|||
| * It requests more DASH than the credit pool contains | |||
| * The withdrawal would result in more than a 2000 DASH reduction in the credit pool over the 576 block-window | |||
There was a problem hiding this comment.
over the past 576 blocks instead?
There was a problem hiding this comment.
over the past 576 blocks instead?
that's same wording as below, if change this one - maybe should update both lines then:
- The withdrawal would result in more than a 1000 DASH reduction in the credit pool over the 576 block-window
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dash Core v22 makes simplifies withdrawal safety rules and also makes them less restrictive as implemented in dashpay/dash#6369.