Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: merge bitcoin#23499, #23832, #24136, #24265, #23819, #23595, #24486, #15423, #24784, #24956, #25016, #25060 (auxiliary backports: part 21) #6370

Merged
merged 13 commits into from
Oct 30, 2024
Merged

backport: merge bitcoin#23499, #23832, #24136, #24265, #23819, #23595, #24486, #15423, #24784, #24956, #25016, #25060 (auxiliary backports: part 21) #6370

merged 13 commits into from
Oct 30, 2024

Conversation

kwvg
Copy link
Collaborator

@kwvg kwvg commented Oct 28, 2024 •
edited
Loading

Breaking Changes

None expected.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (note: N/A)
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation (note: N/A)
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@kwvg kwvg changed the title backport: merge bitcoin#23499, #23832, #24136, #24265, #23819, #23595, #24486, #15423, #24784, #24956, #25016, #25060 backport: merge bitcoin#23499, #23832, #24136, #24265, #23819, #23595, #24486, #15423, #24784, #24956, #25016, #25060 (auxiliary backports: part 21) Oct 28, 2024
@kwvg kwvg added this to the 22 milestone Oct 28, 2024
@kwvg kwvg marked this pull request as ready for review October 28, 2024 18:54
PastaPastaPasta
PastaPastaPasta previously approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK b9177a3

UdjinM6
UdjinM6 requested changes Oct 28, 2024
View reviewed changes
src/validation.cpp Outdated Show resolved Hide resolved
src/rpc/blockchain.cpp Show resolved Hide resolved
kwvg and others added 9 commits October 29, 2024 07:52
@kwvg @UdjinM6
merge bitcoin#23819: don't serialize block hash twice
c2defe7 
continuation of 7f2c84b in dash#5042

Co-authored-by: UdjinM6 <[email protected]>
@kwvg
merge bitcoin#23595: Add ParseHex<std::byte>() helper
aa945c2 
includes:
- facd1fb

continuation of cf4522f in dash#5901
@kwvg
merge bitcoin#24486: dedup sqlite blob binding
74dceb3
@kwvg
merge bitcoin#15423: Query Tor for correct -onion configuration
092a11e
@kwvg
merge bitcoin#24784: deduplicate integer serialization in RollingBloo…
80615b8 
…m benchmark
@kwvg
refactor: use loop to iterate through SoftForkDescPushBack args
87b556d
@kwvg
merge bitcoin#24956: Call CHECK_NONFATAL only once where needed
99d028e
@kwvg
merge bitcoin#25016: GetFirstStoredBlock() and getblockchaininfo foll…
cfda9e5 
…ow-ups
@kwvg
merge bitcoin#25060: add LIFETIMEBOUND to GetFirstStoredBlock()::star…
0232003 
…t_time
UdjinM6
UdjinM6 approved these changes Oct 29, 2024
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 0232003

@PastaPastaPasta PastaPastaPasta merged commit 5dbe58c into dashpay:develop Oct 30, 2024
30 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@knst knst Awaiting requested review from knst

@PastaPastaPasta PastaPastaPasta Awaiting requested review from PastaPastaPasta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
22
Development

Successfully merging this pull request may close these issues.
3 participants
@kwvg @UdjinM6 @PastaPastaPasta