Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: increased withdrawal limits to flat 2000 from v22 #6369

Merged
merged 7 commits into from
Oct 28, 2024
Merged

feat: increased withdrawal limits to flat 2000 from v22 #6369

merged 7 commits into from
Oct 28, 2024
+66 −23

Commits on Oct 28, 2024

  1. feat: update limit of withdrawals to flat 2000 starting from v22

    @knst
    knst committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    31ca8a4 View commit details
    Browse the repository at this point in the history

  2. fix: string in credit pool logs 'previous' is renamed to recently unl… 

    …ocked
    @knst
    knst committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    5b0a2f5 View commit details
    Browse the repository at this point in the history

  3. docs: add release notes for withdrawal changes in v22

    @knst
    knst committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    ef6190e View commit details
    Browse the repository at this point in the history

  4. style: apply clang-format

    @knst
    knst committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    a51ade5 View commit details
    Browse the repository at this point in the history

  5. feat: generate less blocks in feature_asset_locks.py to make it faster

    @knst
    knst committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    877aa08 View commit details
    Browse the repository at this point in the history

  6. feat: update some asserts related to CreditPool in consensus code to … 

    …exceptions
    @knst
    knst committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    c97f5f5 View commit details
    Browse the repository at this point in the history

  7. feat: replace assert to error in p2p code of Asset Lock 

    It is impossible situation which will never happen.
But better to change it to exception for better error-prune implementation
in case someone will decide to change this code:

    const auto quorums = qman.ScanQuorums(llmqType, pindexTip, quorums_to_scan);
    if (bool isActive = std::any_of(quorums.begin(), quorums.end(), [&](const auto &q) { return q->qc->quorumHash == quorumHash; }); !isActive) {
        return state.Invalid(TxValidationResult::TX_CONSENSUS, "bad-assetunlock-too-old-quorum");
    }
    ...
    const auto quorum = qman.GetQuorum(llmqType, quorumHash);
    assert(quorum); <-- for sure exist because we just scanned quorums
    @knst
    knst committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    e43ca62 View commit details
    Browse the repository at this point in the history