backport: bitcoin/bitcoin#22229 test: consolidate to f-strings and related fixes #6357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oin's codebase
|
This pull request has conflicts, please rebase. |
That's a lie! |
UdjinM6
requested changes
Oct 24, 2024
UdjinM6
previously approved these changes
Oct 24, 2024
PastaPastaPasta
previously approved these changes
Oct 24, 2024
UdjinM6
dismissed
their stale review
linux64_sqlite-test keeps failing on feature_notifications.py
|
CI fails for sqlite build https://gitlab.com/dashpay/dash/-/jobs/8184393307 |
|
reverting/dropping 1b6baa5 fixes it https://gitlab.com/UdjinM6/dash/-/pipelines/1511972465 |
yes I am looking to the same commit, but not sure how exactly to fix it yet. I will try to find a fix for it and if it is not easy I will just drop it. |
68faa87 test: use f-strings in mining_*.py tests (fanquake) c2a5d56 test: use f-strings in interface_*.py tests (fanquake) 86d9582 test: use f-strings in feature_proxy.py (fanquake) 31bdb33 test: use f-strings in feature_segwit.py (fanquake) b166d54 test: use f-strings in feature_versionbits_warning.py (fanquake) cf6d66b test: use f-strings in feature_settings.py (fanquake) 6651d77 test: use f-strings in feature_pruning.py (fanquake) 961f581 test: use f-strings in feature_notifications.py (fanquake) 1a546e6 test: use f-strings in feature_minchainwork.py (fanquake) 6679ece test: use f-strings in feature_logging.py (fanquake) fb63393 test: use f-strings in feature_loadblock.py (fanquake) e9ca8b2 test: use f-strings in feature_help.py (fanquake) ff7e330 test: use f-strings in feature_filelock.py (fanquake) d5a6adc test: use f-strings in feature_fee_estimation.py (fanquake) a2de33c test: use f-strings in feature_dersig.py (fanquake) a2502cc test: use f-strings in feature_dbcrash.py (fanquake) 3e2f84e test: use f-strings in feature_csv_activation.py (fanquake) e2f1fd8 test: use f-strings in feature_config_args.py (fanquake) 36d33d3 test: use f-strings in feature_cltv.py (fanquake) dca173c test: use f-strings in feature_blocksdir.py (fanquake) 5453e87 test: use f-strings in feature_backwards_compatibility.py (fanquake) 6f3d5ad test: use f-strings in feature_asmap.py (fanquake) Pull request description: Rather than using 3 different ways to build/format strings (sometimes all in the same test, i.e [`feature_config_args.py`](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_config_args.py)), consolidate to using [f-strings (3.6+)](https://docs.python.org/3/reference/lexical_analysis.html#f-strings), which are generally more concise / readable, as well as more performant than existing methods. This deals with the `feature_*.py`, `interface_*.py` and `mining_*.py` tests. See also: [PEP 498](https://www.python.org/dev/peps/pep-0498/) ACKs for top commit: mjdietzx: reACK 68faa87 Zero-1729: crACK 68faa87 Tree-SHA512: d4e1a42e07d96d2c552387a46da1534223c4ce408703d7568ad2ef580797dd68d9695b8d19666b567af37f44de6e430e8be5db5d5404ba8fcecf9f5b026a6efb
|
I dropped that problematic commit for feature_notifications.py; will resolve issue some other day |
UdjinM6
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Just one backport bitcoin#22229 because it is a big size, even though there's nothing non-trivial in it.
Though, even it is called as part I, there has not been part II yet.
What was done?
Some preparation, code unifications to make bitcoin#22229 with less conflicts and finally backport of itselfl.
How Has This Been Tested?
Run unit & functional test
Breaking Changes
N/A
Checklist: