fix: specify crowdnode worker foreground service type #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashEngineering
force-pushed
the
bugfix-crowdnode-foreground
branch
from
1d09b9a
to
3920476
Compare
HashEngineering
commented
Oct 3, 2024
Comment on lines
+70
to
+85
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) { | ||
| setForeground( | ||
| ForegroundInfo( | ||
| operation.hashCode(), | ||
| notification, | ||
| ServiceInfo.FOREGROUND_SERVICE_TYPE_DATA_SYNC | ||
| ) | ||
| ) | ||
| } else { | ||
| setForeground( | ||
| ForegroundInfo( | ||
| operation.hashCode(), | ||
| notification | ||
| ) | ||
| ) | ||
| } |
There was a problem hiding this comment.
This is the foreground service fix.
HashEngineering
commented
Oct 3, 2024
| @@ -104,7 +104,7 @@ class ShortcutsPane(context: Context, attrs: AttributeSet) : FlexboxLayout(conte | |||
| secureNowButton, | |||
| explore, | |||
| receiveButton, | |||
| payToContactButton, | |||
| if (Constants.SUPPORTS_PLATFORM) payToContactButton else payToAddressButton, | |||
There was a problem hiding this comment.
This is the ShortcutPane fix
HashEngineering
commented
Oct 3, 2024
Comment on lines
+141
to
+143
| private val userAgentDaoMock = mockk<UserAlertDao> { | ||
| every { observe(any()) } returns flow { } | ||
| } |
There was a problem hiding this comment.
I'm not sure why this problem started happening now and not previously on the dashpay branch.
observeBlockchainState_replaying_notSynced started to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Related PR's and Dependencies
Screenshots / Videos
How Has This Been Tested?
Checklist: