Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support core 21 #1293

Merged
merged 2 commits into from
Aug 6, 2024
Merged

feat: support core 21 #1293

merged 2 commits into from
Aug 6, 2024

Conversation

HashEngineering
Copy link
Collaborator

@HashEngineering HashEngineering commented Jul 12, 2024 •
edited
Loading

Issue being fixed or feature implemented

Support core 21, mostly via dashj 21.0.0

Related PR's and Dependencies

dashpay/dashj#257
dashpay/dashj#256

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

@HashEngineering HashEngineering self-assigned this Jul 12, 2024
@HashEngineering HashEngineering marked this pull request as ready for review July 24, 2024 22:07
Syn-McJ
Syn-McJ approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@HashEngineering
Copy link
Collaborator Author

CI will be fixed in the next PR.

@HashEngineering HashEngineering merged commit 07d06b3 into master Aug 6, 2024
1 of 2 checks passed
@HashEngineering HashEngineering deleted the feature-core-21 branch August 29, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Syn-McJ Syn-McJ Syn-McJ approved these changes

Assignees

@HashEngineering HashEngineering

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HashEngineering @Syn-McJ