feat: add jetpack compose #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashEngineering
commented
Apr 18, 2024
HashEngineering
commented
Apr 18, 2024
HashEngineering
commented
Apr 18, 2024
common/src/main/java/org/dash/wallet/common/ui/components/MenuItem.kt
Outdated
Show resolved
Hide resolved
HashEngineering
commented
Apr 18, 2024
Syn-McJ
reviewed
Apr 18, 2024
Syn-McJ
requested changes
Apr 18, 2024
Syn-McJ
reviewed
Apr 18, 2024
HashEngineering
commented
Apr 19, 2024
Comment on lines
+77
to
78
| @Deprecated("Deprecated in Java") | ||
| override fun onPreExecute() { |
There was a problem hiding this comment.
these were added after running the 1.8 to 1.9 migration tool.
HashEngineering
commented
Apr 22, 2024
Comment on lines
+62
to
+72
| walletUriResultLauncher = registerForActivityResult(ActivityResultContracts.StartActivityForResult()) { result -> | ||
| var resultIntent: Intent? = null | ||
| if (result.resultCode == Activity.RESULT_OK) { | ||
| val data = result.data | ||
| val requestData = intent.data | ||
| val transactionHash = BitcoinIntegration.transactionHashFromResult(data) | ||
| resultIntent = WalletUri.createPaymentResult(requestData, transactionHash) | ||
| } | ||
| setResult(result.resultCode, resultIntent) | ||
| finish() | ||
| } |
There was a problem hiding this comment.
replaces deprecated onActiivtyResult
There was a problem hiding this comment.
This is not used internally, but when apps externally request data using dashwallet://...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Related PR's and Dependencies
Screenshots / Videos
How Has This Been Tested?
Checklist: