feat(zenledger): add entry point and export functionality to tools menu #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashEngineering
commented
Apr 3, 2024
Comment on lines
+51
to
+87
| val addresses = if (transactions.isEmpty()) { | ||
| listOf( | ||
| ZenLedgerAddress( | ||
| DASH_CURRENCY, | ||
| DASH_CURRENCY, | ||
| wallet.currentAddress(KeyChain.KeyPurpose.RECEIVE_FUNDS).toBase58(), | ||
| "Dash Wallet" | ||
| ) | ||
| ) | ||
| } else { | ||
| val addresses = arrayListOf<ZenLedgerAddress>() | ||
| transactions.forEach { tx -> | ||
| tx.outputs.forEach { output -> | ||
| if (output.isMine(wallet)) { | ||
| log.info( | ||
| output.value.toFriendlyString(), | ||
| Address.fromPubKeyHash( | ||
| Constants.NETWORK_PARAMETERS, | ||
| ScriptPattern.extractHashFromP2PKH(output.scriptPubKey) | ||
| ).toBase58() | ||
| ) | ||
| addresses.add( | ||
| ZenLedgerAddress( | ||
| DASH_CURRENCY, | ||
| DASH_CURRENCY, | ||
| Address.fromPubKeyHash( | ||
| Constants.NETWORK_PARAMETERS, | ||
| ScriptPattern.extractHashFromP2PKH(output.scriptPubKey) | ||
| ).toBase58(), | ||
| "Dash Wallet" | ||
| ) | ||
| ) | ||
| } | ||
| } | ||
| } | ||
| addresses | ||
| } |
There was a problem hiding this comment.
If there are no transactions, then we will send the current receive address. This way the flow can proceed to the end with ZenLedger. If no addresses are submitted, then ZenLedger returns an error with their create portfolio API.
If there are transactions, then we will scan all transaction outputs and add the addresses of the outputs that the wallet owns.
HashEngineering
commented
Apr 4, 2024
Comment on lines
62
to
64
| Constants.HTTP_CLIENT.newBuilder() | ||
| .addInterceptor(HttpLoggingInterceptor { log.info(it) }.setLevel(HttpLoggingInterceptor.Level.BODY)) | ||
| .build() |
There was a problem hiding this comment.
before merging, I would like to remove this logging -- or disable it in release, enable in debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Related PR's and Dependencies
Screenshots / Videos
How Has This Been Tested?
Checklist: